[MetricsAdvisor] Updated DataFeedSource constructors#22427
[MetricsAdvisor] Updated DataFeedSource constructors#22427kinelski merged 3 commits intoAzure:camaiaor/ma-beta5from
Conversation
There was a problem hiding this comment.
Not actually supported by the service. Other properties are required now. We'll possibly add this constructor back again as new types of credentials are added.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
There was a problem hiding this comment.
do u want to add a test for it? I think as is fine, but just in case u want to check query empty and the exception and etc...
There was a problem hiding this comment.
Added tests for new ctors.
a9fb5da to
91d1922
Compare
Adding/removing data source constructors based on what parameters are currently required by the service (fixes #21616).